fix: Do not panic when /proc/modules does not exist #139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Does that mean you will follow up with another PR? |
orhun
reviewed
Apr 1, 2024
|
Yes. I'll try to add it with another PR. |
orhun
reviewed
Apr 1, 2024
orhun
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As it mentioned in issue I linked below, chromebooks and few types of generic linux kernels does not include
/proc/modulesso program panics.Motivation and Context
fixes #138
I'll also implement parsing to return empty set of modules.
How Has This Been Tested?
I couldn't test this bug fix, because I don't use chromebook or generic linux kernel, so I hope who created issue can test on his device. If there are any ways to reproduce that kernel types please let me know :)
Types of changes
Checklist: